Ensure sso access token is always refreshed on expiry #1933
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure we catch throw connectivity errors from background calls and add a fallback to refresh the accesstoken in the reconnection flow.
I also add end to end tests to make sure we don't accidentally break SSO in the future
In addition I solve a state where all queries fail with "client authorized", but Browser will still not trigger its lost connection flow.
There was a filter put in 6 years ago to not needlessly trigger the connection flow before the user was connected (so don't trigger on authorization errors) and a more general fix was put in place 3 years ago superseded that (only trigger flow if we are supposed to be connected). The first fix is no longer needed, but didn't do any harm - except if your access_token expires and you don't catch the first "TokenExpiredError" and only see the "Unauthorized" errors.